Add package extension for visualization of colorings#149
Merged
gdalle merged 31 commits intoJuliaDiff:mainfrom Oct 9, 2024
Merged
Add package extension for visualization of colorings#149gdalle merged 31 commits intoJuliaDiff:mainfrom
gdalle merged 31 commits intoJuliaDiff:mainfrom
Conversation
Contributor
Author
|
The code is written to make it as easy as possible to extend |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 12 13 +1
Lines 884 1010 +126
==========================================
+ Hits 884 1010 +126 ☔ View full report in Codecov by Sentry. |
gdalle
requested changes
Oct 8, 2024
Member
gdalle
left a comment
There was a problem hiding this comment.
Thanks for this very pretty contribution!
Contributor
Author
|
This is what the new doc page looks like: |
gdalle
reviewed
Oct 9, 2024
gdalle
reviewed
Oct 9, 2024
adrhill
commented
Oct 9, 2024
Contributor
Author
adrhill
left a comment
There was a problem hiding this comment.
Excited for this!
Contributor
Author
|
Would be nice to have a release tagged for this! :) |
Member
Collaborator
|
Thanks @adrhill for working on that! |
Contributor
Author
|
Check it out in action! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an un-exported
show_colorsfunction as well as tests and documentation for it.The function has some options for customization:
Currently the function errors when the matrix-coloring has more colors than the provided colorscheme. I can add some color cycling to circumvent this if desired.
Edit: turned this from an Images.jl extension to a ColorTypes.jl extension to make it more light-weight.