Optimize star coloring and its postprocessing#171
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
@gdalle The failures are related to the decompression of bicoloring. |
gdalle
reviewed
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1423 1447 +24
=========================================
+ Hits 1423 1447 +24 ☔ View full report in Codecov by Sentry. |
gdalle
approved these changes
Feb 12, 2025
Collaborator
Author
|
The gain in terms of storage is between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
star.nb_spokesto count the number of spokes for each star during the star coloring.nb_spokesto know the size of each vector inspokeswhen creating aStarSet._update_stars!to minimize duplicated access in the dictionarystar.