Skip to content

Detect stars in the forest for acyclic coloring#180

Merged
gdalle merged 1 commit intomainfrom
detect_stars_in_forest
Mar 20, 2025
Merged

Detect stars in the forest for acyclic coloring#180
gdalle merged 1 commit intomainfrom
detect_stars_in_forest

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Feb 13, 2025 •
edited
Loading

close #178, #181
Add a vector of booleans is_star to the TreeSet so that we can enable more efficient post-processing for acyclic coloring by determining if a tree is a star (trivial or non-trivial).

@amontoison amontoison added the benchmark Run benchmarks on PR label Feb 13, 2025
@amontoison amontoison requested a review from gdalle February 13, 2025 07:43
@amontoison amontoison mentioned this pull request Feb 13, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2fba12e) to head (3de24bc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1635      1647   +12     
=========================================
+ Hits          1635      1647   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2025 •
edited
Loading

Benchmark Results

main 3de24bc... main/3de24bcf832520...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 2.99 ± 0.19 ms 3 ± 0.19 ms 0.997
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 8.01 ± 0.39 ms 7.96 ± 0.35 ms 1.01
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 20 ± 0.37 ms 19.7 ± 0.53 ms 1.01
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 5.61 s 5.73 s 0.978
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.487 ± 0.016 s 0.501 ± 0.035 s 0.971
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 1.7 ± 0.015 s 1.68 ± 0.019 s 1.01
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 7.96 ± 0.098 ms 8.04 ± 0.1 ms 0.99
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 19.8 ± 0.17 ms 20 ± 0.19 ms 0.991
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.0444 ± 0.00036 s 0.0446 ± 0.00031 s 0.994
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 10.1 s 10.3 s 0.982
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 1.29 ± 0.09 s 1.39 ± 0.094 s 0.932
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 4.1 ± 0.066 s 3.95 ± 0.072 s 1.04
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.494 ± 0.014 ms 0.486 ± 0.014 ms 1.02
coloring/nonsymmetric/column/direct/n=1000/p=0.005 1.22 ± 0.2 ms 1.2 ± 0.2 ms 1.01
coloring/nonsymmetric/column/direct/n=1000/p=0.01 3.02 ± 0.037 ms 2.98 ± 0.044 ms 1.01
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.517 ± 0.015 s 0.504 ± 0.0062 s 1.03
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.0816 ± 0.012 s 0.0813 ± 0.012 s 1
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.206 ± 0.0087 s 0.203 ± 0.012 s 1.01
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.485 ± 0.014 ms 0.483 ± 0.015 ms 1
coloring/nonsymmetric/row/direct/n=1000/p=0.005 1.21 ± 0.19 ms 1.21 ± 0.2 ms 1
coloring/nonsymmetric/row/direct/n=1000/p=0.01 3.02 ± 0.033 ms 3.07 ± 0.025 ms 0.985
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.478 ± 0.006 s 0.503 ± 0.012 s 0.95
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.0791 ± 0.012 s 0.0789 ± 0.012 s 1
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.195 ± 0.0082 s 0.196 ± 0.012 s 0.994
coloring/symmetric/column/direct/n=1000/p=0.002 1.56 ± 0.025 ms 1.55 ± 0.025 ms 1
coloring/symmetric/column/direct/n=1000/p=0.005 4.01 ± 0.029 ms 4 ± 0.033 ms 1
coloring/symmetric/column/direct/n=1000/p=0.01 9.76 ± 0.075 ms 9.78 ± 0.075 ms 0.998
coloring/symmetric/column/direct/n=100000/p=0.0001 2.06 ± 0.026 s 2.04 ± 0.043 s 1.01
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.22 ± 0.0093 s 0.219 ± 0.0049 s 1.01
coloring/symmetric/column/direct/n=100000/p=5.0e-5 0.752 ± 0.031 s 0.654 ± 0.016 s 1.15
coloring/symmetric/column/substitution/n=1000/p=0.002 3.99 ± 0.04 ms 4 ± 0.054 ms 0.997
coloring/symmetric/column/substitution/n=1000/p=0.005 9.75 ± 0.093 ms 9.77 ± 0.086 ms 0.998
coloring/symmetric/column/substitution/n=1000/p=0.01 21.7 ± 0.21 ms 21.8 ± 0.13 ms 0.995
coloring/symmetric/column/substitution/n=100000/p=0.0001 3.98 ± 0.09 s 3.97 ± 0.086 s 1
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 0.536 ± 0.007 s 0.533 ± 0.0046 s 1.01
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 1.54 ± 0.06 s 1.57 ± 0.041 s 0.985
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.151 ± 0.0054 ms 0.143 ± 0.0089 ms 1.05
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.242 ± 0.0086 ms 0.232 ± 0.0092 ms 1.04
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.378 ± 0.016 ms 0.372 ± 0.011 ms 1.01
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.0941 ± 0.0043 s 0.0949 ± 0.004 s 0.991
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.0321 ± 0.00056 s 0.032 ± 0.00068 s 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.06 ± 0.0032 s 0.0612 ± 0.0016 s 0.98
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.156 ± 0.0066 ms 0.164 ± 0.0071 ms 0.949
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.314 ± 0.01 ms 0.314 ± 0.01 ms 0.999
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.607 ± 0.012 ms 0.623 ± 0.012 ms 0.974
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.18 ± 0.0076 s 0.184 ± 0.0061 s 0.976
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.0404 ± 0.0012 s 0.0389 ± 0.0023 s 1.04
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.0822 ± 0.0034 s 0.0853 ± 0.0092 s 0.964
decompress/nonsymmetric/column/direct/n=1000/p=0.002 27 ± 1.6 μs 26.8 ± 1.3 μs 1.01
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.0505 ± 0.0022 ms 0.0504 ± 0.0021 ms 1
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.0917 ± 0.0043 ms 0.0922 ± 0.0035 ms 0.995
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 28.5 ± 2.3 ms 25.3 ± 0.92 ms 1.12
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 5.32 ± 0.41 ms 4.26 ± 0.17 ms 1.25
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 13.2 ± 0.44 ms 12.1 ± 0.35 ms 1.09
decompress/nonsymmetric/row/direct/n=1000/p=0.002 24.5 ± 1.5 μs 26.9 ± 1.3 μs 0.91
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.0434 ± 0.0019 ms 0.0464 ± 0.0014 ms 0.935
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.0766 ± 0.004 ms 0.083 ± 0.0028 ms 0.923
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 11.6 ± 0.73 ms 12.1 ± 0.61 ms 0.956
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 3.13 ± 0.15 ms 3.07 ± 0.11 ms 1.02
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 5.92 ± 0.22 ms 5.9 ± 0.17 ms 1
decompress/symmetric/column/direct/n=1000/p=0.002 25.4 ± 3.1 μs 26.4 ± 2.9 μs 0.963
decompress/symmetric/column/direct/n=1000/p=0.005 0.046 ± 0.0019 ms 0.0466 ± 0.0022 ms 0.987
decompress/symmetric/column/direct/n=1000/p=0.01 0.0839 ± 0.0045 ms 0.0867 ± 0.0042 ms 0.967
decompress/symmetric/column/direct/n=100000/p=0.0001 22.1 ± 1.5 ms 22 ± 0.84 ms 1
decompress/symmetric/column/direct/n=100000/p=2.0e-5 3.92 ± 0.44 ms 3.7 ± 0.54 ms 1.06
decompress/symmetric/column/direct/n=100000/p=5.0e-5 10.6 ± 0.4 ms 10.8 ± 0.27 ms 0.986
decompress/symmetric/column/substitution/n=1000/p=0.002 0.108 ± 0.0032 ms 0.107 ± 0.0026 ms 1.01
decompress/symmetric/column/substitution/n=1000/p=0.005 0.198 ± 0.0081 ms 0.2 ± 0.0079 ms 0.99
decompress/symmetric/column/substitution/n=1000/p=0.01 0.34 ± 0.012 ms 0.394 ± 0.012 ms 0.863
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.1 ± 0.0056 s 0.0907 ± 0.0036 s 1.11
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 25 ± 0.54 ms 27.8 ± 0.37 ms 0.9
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.0537 ± 0.0014 s 0.0508 ± 0.00069 s 1.06
time_to_load 0.287 ± 0.0031 s 0.287 ± 0.002 s 0.998
main 3de24bc... main/3de24bcf832520...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 12.7 k allocs: 3.1 MB 12.7 k allocs: 3.1 MB 1
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 29.4 k allocs: 5.67 MB 29.4 k allocs: 5.67 MB 1
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.0612 M allocs: 10.6 MB 0.0612 M allocs: 10.6 MB 1
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 6.05 M allocs: 1.15 GB 6.05 M allocs: 1.15 GB 1
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 1.18 M allocs: 0.324 GB 1.18 M allocs: 0.324 GB 1
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 2.87 M allocs: 0.635 GB 2.87 M allocs: 0.635 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.0513 M allocs: 6.7 MB 0.0513 M allocs: 6.71 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.0978 M allocs: 12.4 MB 0.0978 M allocs: 12.4 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.187 M allocs: 23.7 MB 0.187 M allocs: 23.7 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 17.9 M allocs: 2.27 GB 17.9 M allocs: 2.27 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 4.93 M allocs: 0.638 GB 4.93 M allocs: 0.638 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 9.54 M allocs: 1.24 GB 9.54 M allocs: 1.24 GB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/symmetric/column/direct/n=1000/p=0.002 6.26 k allocs: 0.902 MB 6.26 k allocs: 0.902 MB 1
coloring/symmetric/column/direct/n=1000/p=0.005 14.5 k allocs: 1.72 MB 14.5 k allocs: 1.72 MB 1
coloring/symmetric/column/direct/n=1000/p=0.01 30.6 k allocs: 3.32 MB 30.6 k allocs: 3.32 MB 1
coloring/symmetric/column/direct/n=100000/p=0.0001 3.02 M allocs: 0.38 GB 3.02 M allocs: 0.38 GB 1
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.589 M allocs: 0.0939 GB 0.589 M allocs: 0.0939 GB 1
coloring/symmetric/column/direct/n=100000/p=5.0e-5 1.44 M allocs: 0.199 GB 1.44 M allocs: 0.199 GB 1
coloring/symmetric/column/substitution/n=1000/p=0.002 25.6 k allocs: 2.91 MB 25.6 k allocs: 2.92 MB 0.999
coloring/symmetric/column/substitution/n=1000/p=0.005 0.0492 M allocs: 5.36 MB 0.0492 M allocs: 5.36 MB 1
coloring/symmetric/column/substitution/n=1000/p=0.01 0.0937 M allocs: 10.6 MB 0.0937 M allocs: 10.6 MB 1
coloring/symmetric/column/substitution/n=100000/p=0.0001 8.95 M allocs: 1 GB 8.95 M allocs: 1 GB 1
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 2.47 M allocs: 0.269 GB 2.47 M allocs: 0.269 GB 0.999
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 4.77 M allocs: 0.543 GB 4.77 M allocs: 0.543 GB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@amontoison amontoison mentioned this pull request Feb 13, 2025
Merged
amontoison
amontoison commented Feb 13, 2025
View reviewed changes
Comment thread src/coloring.jl Outdated
@amontoison amontoison force-pushed the detect_stars_in_forest branch 2 times, most recently from ebfe273 to 461236e Compare February 14, 2025 22:26
gdalle
gdalle requested changes Feb 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please merge main into this branch, most notably to take into account the changes from #179?

@amontoison amontoison force-pushed the detect_stars_in_forest branch from 461236e to 8a90816 Compare February 17, 2025 17:34
@gdalle gdalle closed this Feb 17, 2025
@gdalle gdalle reopened this Feb 17, 2025
@amontoison amontoison force-pushed the detect_stars_in_forest branch from 089e45b to 25681bf Compare February 17, 2025 20:20
@amontoison
Copy link
Copy Markdown
Collaborator Author

amontoison commented Feb 17, 2025 •
edited
Loading

I merged #184 in this branch, it only contained a few modications + a unit tests.

amontoison
amontoison commented Feb 17, 2025
View reviewed changes
Comment thread src/coloring.jl Outdated
gdalle
gdalle requested changes Feb 19, 2025
View reviewed changes
Comment thread src/coloring.jl
Comment thread src/decompression.jl Outdated
gdalle
gdalle requested changes Feb 20, 2025
View reviewed changes
Comment thread src/decompression.jl Outdated
Comment thread src/decompression.jl Outdated
Comment thread src/result.jl Outdated
Comment thread src/decompression.jl Outdated
Comment thread src/decompression.jl Outdated
Comment thread src/decompression.jl Outdated
Comment thread src/decompression.jl Outdated
Comment thread src/decompression.jl Outdated
Comment thread test/allocations.jl Outdated
@amontoison amontoison force-pushed the detect_stars_in_forest branch 4 times, most recently from 2048a48 to 9081eec Compare March 19, 2025 00:46
@amontoison amontoison requested a review from gdalle March 19, 2025 00:47
@amontoison
Copy link
Copy Markdown
Collaborator Author

amontoison commented Mar 19, 2025

@gdalle I simplified the PR a lot, the boolean vector is_star is now only used for the post-processing for acyclic coloring / bicoloring.

@amontoison amontoison force-pushed the detect_stars_in_forest branch from 9081eec to 3de24bc Compare March 19, 2025 00:51
@gdalle gdalle merged commit a113eea into main Mar 20, 2025
6 checks passed
@gdalle gdalle deleted the detect_stars_in_forest branch March 20, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdalle gdalle gdalle approved these changes

Assignees

No one assigned

Labels

benchmark Run benchmarks on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Try to detect the stars during the acyclic coloring

2 participants

@amontoison @gdalle