Skip to content

Update decompression_single_color! for star coloring#217

Merged
gdalle merged 4 commits intomainfrom
amontoison-patch-2
Mar 31, 2025
Merged

Update decompression_single_color! for star coloring#217
gdalle merged 4 commits intomainfrom
amontoison-patch-2

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Mar 31, 2025 •
edited
Loading

It removes the need for the vector spokes.

@amontoison amontoison requested a review from gdalle March 31, 2025 18:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b18bfd) to head (93ae6ff).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #217   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1661      1644   -17     
=========================================
- Hits          1661      1644   -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle
Copy link
Copy Markdown
Member

gdalle commented Mar 31, 2025

Very good idea! If we really don't need it anymore, can you get rid of spokes everywhere in this PR?

@amontoison amontoison added the benchmark Run benchmarks on PR label Mar 31, 2025
@amontoison
Copy link
Copy Markdown
Collaborator Author

amontoison commented Mar 31, 2025

Done @gdalle

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2025

Benchmark Results

main 11ae975... main/11ae975a59b49e...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 2.99 ± 0.18 ms 2.7 ± 0.019 ms 1.11
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 7.95 ± 0.37 ms 6.98 ± 0.081 ms 1.14
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 19.8 ± 0.37 ms 17.7 ± 0.31 ms 1.11
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 5.77 s 4.66 ± 0.079 s 1.24
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.499 ± 0.031 s 0.406 ± 0.0093 s 1.23
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 1.81 ± 0.085 s 1.43 ± 0.069 s 1.27
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 7.27 ± 0.12 ms 7.24 ± 1.2 ms 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 17.7 ± 0.21 ms 17.8 ± 0.7 ms 0.999
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.0394 ± 0.00043 s 0.0395 ± 0.00092 s 0.997
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 9.01 s 9.01 s 0.999
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 1.2 ± 0.06 s 1.15 ± 0.074 s 1.05
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 3.74 ± 0.19 s 3.64 ± 0.065 s 1.03
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.493 ± 0.014 ms 0.485 ± 0.011 ms 1.02
coloring/nonsymmetric/column/direct/n=1000/p=0.005 1.22 ± 0.2 ms 1.2 ± 0.015 ms 1.02
coloring/nonsymmetric/column/direct/n=1000/p=0.01 3.02 ± 0.036 ms 2.99 ± 0.34 ms 1.01
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.512 ± 0.0062 s 0.538 ± 0.032 s 0.951
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.081 ± 0.012 s 0.081 ± 0.0061 s 1
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.208 ± 0.01 s 0.201 ± 0.0044 s 1.03
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.484 ± 0.014 ms 0.484 ± 0.011 ms 1
coloring/nonsymmetric/row/direct/n=1000/p=0.005 1.22 ± 0.2 ms 1.19 ± 0.014 ms 1.02
coloring/nonsymmetric/row/direct/n=1000/p=0.01 3.08 ± 0.03 ms 2.99 ± 0.02 ms 1.03
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.516 ± 0.013 s 0.496 ± 0.011 s 1.04
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.0808 ± 0.012 s 0.0799 ± 0.0059 s 1.01
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.202 ± 0.01 s 0.196 ± 0.0033 s 1.03
coloring/symmetric/column/direct/n=1000/p=0.002 1.55 ± 0.026 ms 1.37 ± 0.18 ms 1.13
coloring/symmetric/column/direct/n=1000/p=0.005 3.99 ± 0.037 ms 3.55 ± 0.056 ms 1.13
coloring/symmetric/column/direct/n=1000/p=0.01 9.78 ± 0.095 ms 8.79 ± 0.063 ms 1.11
coloring/symmetric/column/direct/n=100000/p=0.0001 2.95 ± 0.067 s 1.84 ± 0.047 s 1.61
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.233 ± 0.015 s 0.19 ± 0.0049 s 1.23
coloring/symmetric/column/direct/n=100000/p=5.0e-5 0.914 ± 0.1 s 0.693 ± 0.083 s 1.32
coloring/symmetric/column/substitution/n=1000/p=0.002 3.65 ± 0.05 ms 3.66 ± 0.5 ms 0.997
coloring/symmetric/column/substitution/n=1000/p=0.005 8.78 ± 0.094 ms 8.81 ± 0.2 ms 0.996
coloring/symmetric/column/substitution/n=1000/p=0.01 19.9 ± 0.48 ms 19.7 ± 0.22 ms 1.01
coloring/symmetric/column/substitution/n=100000/p=0.0001 4.28 ± 0.12 s 4.02 ± 0.15 s 1.06
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 0.512 ± 0.021 s 0.545 ± 0.055 s 0.94
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 1.64 ± 0.07 s 1.67 ± 0.0046 s 0.983
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.145 ± 0.0088 ms 0.139 ± 0.0053 ms 1.04
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.237 ± 0.0084 ms 0.23 ± 0.0081 ms 1.03
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.368 ± 0.011 ms 0.379 ± 0.01 ms 0.971
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.0979 ± 0.0034 s 0.0914 ± 0.0021 s 1.07
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.0346 ± 0.001 s 31.5 ± 1.8 ms 1.1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.058 ± 0.001 s 0.059 ± 0.0014 s 0.983
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.158 ± 0.008 ms 0.161 ± 0.0056 ms 0.986
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.314 ± 0.01 ms 0.312 ± 0.01 ms 1.01
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.629 ± 0.014 ms 0.608 ± 0.013 ms 1.03
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.248 ± 0.011 s 0.228 ± 0.034 s 1.09
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.0492 ± 0.0048 s 0.0395 ± 0.0034 s 1.24
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.113 ± 0.0095 s 0.084 ± 0.0057 s 1.34
decompress/nonsymmetric/column/direct/n=1000/p=0.002 27.3 ± 1.3 μs 24.7 ± 1.1 μs 1.1
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.0508 ± 0.0022 ms 0.048 ± 0.0018 ms 1.06
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.0892 ± 0.0042 ms 0.0881 ± 0.0035 ms 1.01
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 27.7 ± 1.5 ms 24 ± 1.5 ms 1.16
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 5.34 ± 0.36 ms 4.07 ± 0.23 ms 1.31
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 13.2 ± 0.59 ms 11.1 ± 0.34 ms 1.19
decompress/nonsymmetric/row/direct/n=1000/p=0.002 25.5 ± 1.4 μs 24.1 ± 1.1 μs 1.06
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.0439 ± 0.002 ms 0.0415 ± 0.0016 ms 1.06
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.0837 ± 0.0075 ms 0.0725 ± 0.003 ms 1.15
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 12 ± 0.75 ms 11 ± 0.83 ms 1.09
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 3.45 ± 0.27 ms 2.85 ± 0.11 ms 1.21
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 6.16 ± 0.35 ms 5.43 ± 0.2 ms 1.13
decompress/symmetric/column/direct/n=1000/p=0.002 25.8 ± 2.4 μs 25.4 ± 1.6 μs 1.02
decompress/symmetric/column/direct/n=1000/p=0.005 0.046 ± 0.0017 ms 0.0474 ± 0.0014 ms 0.97
decompress/symmetric/column/direct/n=1000/p=0.01 0.0832 ± 0.0038 ms 0.0849 ± 0.0045 ms 0.98
decompress/symmetric/column/direct/n=100000/p=0.0001 21.1 ± 1.2 ms 22.7 ± 1.9 ms 0.93
decompress/symmetric/column/direct/n=100000/p=2.0e-5 3.87 ± 0.55 ms 3.66 ± 0.43 ms 1.06
decompress/symmetric/column/direct/n=100000/p=5.0e-5 10.4 ± 0.33 ms 10.9 ± 0.48 ms 0.96
decompress/symmetric/column/substitution/n=1000/p=0.002 0.106 ± 0.003 ms 0.0974 ± 0.0029 ms 1.09
decompress/symmetric/column/substitution/n=1000/p=0.005 0.194 ± 0.0076 ms 0.173 ± 0.0072 ms 1.12
decompress/symmetric/column/substitution/n=1000/p=0.01 0.345 ± 0.011 ms 0.332 ± 0.011 ms 1.04
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.107 ± 0.0072 s 0.0963 ± 0.0048 s 1.11
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 26.3 ± 0.44 ms 26.3 ± 0.71 ms 0.999
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.0487 ± 0.0012 s 0.0476 ± 0.0022 s 1.02
time_to_load 0.222 ± 0.0018 s 0.219 ± 0.0039 s 1.01
main 11ae975... main/11ae975a59b49e...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 12.7 k allocs: 3.1 MB 0.48 k allocs: 2.52 MB 1.23
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 29.4 k allocs: 5.67 MB 0.49 k allocs: 4.29 MB 1.32
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.0612 M allocs: 10.6 MB 0.5 k allocs: 7.72 MB 1.38
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 6.05 M allocs: 1.15 GB 0.56 k allocs: 0.837 GB 1.37
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 1.18 M allocs: 0.324 GB 0.53 k allocs: 0.271 GB 1.2
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 2.87 M allocs: 0.635 GB 0.55 k allocs: 0.485 GB 1.31
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.0513 M allocs: 6.61 MB 0.0513 M allocs: 6.61 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.0978 M allocs: 12 MB 0.0978 M allocs: 12 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.187 M allocs: 22.8 MB 0.187 M allocs: 22.8 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 17.9 M allocs: 2.2 GB 17.9 M allocs: 2.2 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 4.93 M allocs: 0.623 GB 4.93 M allocs: 0.623 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 9.54 M allocs: 1.21 GB 9.54 M allocs: 1.21 GB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/symmetric/column/direct/n=1000/p=0.002 6.26 k allocs: 0.902 MB 0.21 k allocs: 0.633 MB 1.42
coloring/symmetric/column/direct/n=1000/p=0.005 14.5 k allocs: 1.72 MB 0.22 k allocs: 1.06 MB 1.62
coloring/symmetric/column/direct/n=1000/p=0.01 30.6 k allocs: 3.32 MB 0.23 k allocs: 1.9 MB 1.75
coloring/symmetric/column/direct/n=100000/p=0.0001 3.02 M allocs: 0.38 GB 0.29 k allocs: 0.227 GB 1.68
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.589 M allocs: 0.0939 GB 0.26 k allocs: 0.0679 GB 1.38
coloring/symmetric/column/direct/n=100000/p=5.0e-5 1.44 M allocs: 0.199 GB 0.28 k allocs: 0.125 GB 1.59
coloring/symmetric/column/substitution/n=1000/p=0.002 25.6 k allocs: 2.84 MB 25.6 k allocs: 2.84 MB 1
coloring/symmetric/column/substitution/n=1000/p=0.005 0.0492 M allocs: 5.17 MB 0.0492 M allocs: 5.17 MB 1
coloring/symmetric/column/substitution/n=1000/p=0.01 0.0937 M allocs: 10.3 MB 0.0937 M allocs: 10.3 MB 1
coloring/symmetric/column/substitution/n=100000/p=0.0001 8.95 M allocs: 0.965 GB 8.95 M allocs: 0.965 GB 1
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 2.47 M allocs: 0.262 GB 2.47 M allocs: 0.262 GB 1
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 4.77 M allocs: 0.525 GB 4.77 M allocs: 0.525 GB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@gdalle gdalle removed the benchmark Run benchmarks on PR label Mar 31, 2025
gdalle
gdalle reviewed Mar 31, 2025
View reviewed changes
Comment thread src/decompression.jl Outdated
gdalle
gdalle reviewed Mar 31, 2025
View reviewed changes
Comment thread src/decompression.jl
gdalle
gdalle reviewed Mar 31, 2025
View reviewed changes
Comment thread src/decompression.jl
@gdalle gdalle force-pushed the amontoison-patch-2 branch from f376780 to 93ae6ff Compare March 31, 2025 19:55
@gdalle gdalle merged commit 3711558 into main Mar 31, 2025
8 of 10 checks passed
@amontoison amontoison deleted the amontoison-patch-2 branch March 31, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdalle gdalle gdalle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amontoison @gdalle