Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1716 1720 +4
=========================================
+ Hits 1716 1720 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amontoison
reviewed
Apr 2, 2025
Co-authored-by: Alexis Montoison <35051714+amontoison@users.noreply.github.com>
amontoison
reviewed
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is that if we propagate integer types carefully, we could store all indices in
Int32whenever that is enough, leading to a 2x reduction of memory footprint.Caveats:
Tis able to store the vector of colors doesn't mean it is able to store every vertex.T1) and colors (often calledT2)Still a draft, don't merge yet because I fear this might make some existing code error. Also needs tests on
Int32indices.