Add decompress_row! and decompress_column!#26
Closed
amontoison wants to merge 2 commits intoJuliaDiff:mainfrom
Closed
Add decompress_row! and decompress_column!#26amontoison wants to merge 2 commits intoJuliaDiff:mainfrom
amontoison wants to merge 2 commits intoJuliaDiff:mainfrom
Conversation
5b6e953 to
2b57c48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 97.81% 93.79% -4.02%
==========================================
Files 9 9
Lines 366 419 +53
==========================================
+ Hits 358 393 +35
- Misses 8 26 +18 ☔ View full report in Codecov by Sentry. |
Member
|
I understand the purpose of this, but for now let's keep it on the back burner. It is conceptually simpler to reason in terms of full matrices, and when we move to smaller colorings that require linear systems, we'll need the full matrix anyway. I have opened #30 to keep track and discuss further. |
Member
|
This no longer fits within the new framework, closing while we figure out if we really need it (note that it wouldn't work with substitution decompression) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decompress_row!anddecompress_column!decompress_rows!anddecompress_rowscc @gdalle