Skip to content

Add decompress_row! and decompress_column!#26

Closed
amontoison wants to merge 2 commits intoJuliaDiff:mainfrom
amontoison:decompression_column_row
Closed

Add decompress_row! and decompress_column!#26
amontoison wants to merge 2 commits intoJuliaDiff:mainfrom
amontoison:decompression_column_row

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Jul 17, 2024

  • Add decompress_row! and decompress_column!
  • Fix a typo in the docstring of decompress_rows! and decompress_rows

cc @gdalle

@amontoison amontoison force-pushed the decompression_column_row branch from 5b6e953 to 2b57c48 Compare July 17, 2024 22:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 66.03774% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.79%. Comparing base (83a1330) to head (949b93a).

Files Patch % Lines
src/decompression.jl 66.03% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   97.81%   93.79%   -4.02%     
==========================================
  Files           9        9              
  Lines         366      419      +53     
==========================================
+ Hits          358      393      +35     
- Misses          8       26      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Copy Markdown
Member

gdalle commented Jul 18, 2024

I understand the purpose of this, but for now let's keep it on the back burner. It is conceptually simpler to reason in terms of full matrices, and when we move to smaller colorings that require linear systems, we'll need the full matrix anyway.

I have opened #30 to keep track and discuss further.

@gdalle gdalle added the wontfix This will not be worked on label Jul 18, 2024
@gdalle
Copy link
Copy Markdown
Member

gdalle commented Aug 12, 2024

This no longer fits within the new framework, closing while we figure out if we really need it (note that it wouldn't work with substitution decompression)

@gdalle gdalle closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants