ensure UnsupportedDecompressionError <: Exception#260
Merged
gdalle merged 1 commit intoJuliaDiff:mainfrom Sep 11, 2025
nsajko:exc
Merged
ensure UnsupportedDecompressionError <: Exception#260gdalle merged 1 commit intoJuliaDiff:mainfrom nsajko:exc
UnsupportedDecompressionError <: Exception#260gdalle merged 1 commit intoJuliaDiff:mainfrom
nsajko:exc
Conversation
Not sure if there is any benefit, but I suppose the intention is for this type, as an exception type, to subtype `Exception`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
===========================================
- Coverage 100.00% 95.71% -4.29%
===========================================
Files 17 17
Lines 1939 1939
===========================================
- Hits 1939 1856 -83
- Misses 0 83 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdalle
approved these changes
Sep 11, 2025
Member
gdalle
left a comment
gdalle
left a comment
There was a problem hiding this comment.
Indeed, thanks!
Merging this, but do you happen to know why the GPU tests fail @amontoison?
Collaborator
|
@gdalle Maybe just a connexion issue? Otherwise, I can reboot the runner on Moonshot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know if there is any benefit, but I suppose the intention is for this type, as an exception type, to subtype
Exception.