Conversation
|
Should we add |
|
You can get it as Don't mind the CI, I'm currently debugging something that only occurs on LTS |
|
@amontoison any idea how this could ever happen for |
|
Okay apparently it's caused by JuliaSparse/SparseArrays.jl#44 and fixed in JuliaLang/julia#40523 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 97.81% 99.16% +1.35%
==========================================
Files 9 9
Lines 366 360 -6
==========================================
- Hits 358 357 -1
+ Misses 8 3 -5 ☔ View full report in Codecov by Sentry. |
|
@amontoison I made a few more changes and updated the PR description accordingly, care to take a second look? |
|
LGTM! |

Warning
Breaking change: bumping version to v0.4.0
Source
column_coloring_detailed,row_coloring_detailedandsymmetric_coloring_detailed. Make the ADTypes interface fall back on those (we'll see once this stabilizes if it is worth upstreaming).AbstractColoringResult, which must then be used in decompression routines. A minima, this object contains thecolorvector and thegroupvector. There is also one specific implementation forSparseMatrixCSC, where decompression indices are stored.AbstractColoringResult{partition,symmetric,decompression}.decompress_columns,decompress_rowanddecompress_symmetricinto a single symboldecompress, using dispatch on the result type to figure out the right algorithm.Docs
Tests
@amontoison this should be very easy to adapt to sparse GPU matrices