Skip to content

Introduce ColoringProblem#45

Merged
gdalle merged 3 commits intomainfrom
gd/interface
Aug 9, 2024
Merged

Introduce ColoringProblem#45
gdalle merged 3 commits intomainfrom
gd/interface

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Aug 9, 2024

  • Merge column_coloring_detailed, row_coloring_detailed and symmetric_coloring_detailed into a single function coloring.
  • Dispatch on the right version thanks to a new ColoringProblem{structure,partition,decompression} type, where structure in (:nonsymmetric, :symmetric), partition in (:column, :row, :bidirectional) and decompression in (:direct, :substitution).
  • Adjust AbstractColoringResult and its subtypes to reflect the parameters of ColoringProblem.
  • Isolate the code necessary for decompression into SparseMatrixCSC, so that other matrix types can be easily added.
  • Update tests and docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (a0f516c) to head (ed3be14).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   99.18%   99.20%   +0.02%     
==========================================
  Files           9       10       +1     
  Lines         366      377      +11     
==========================================
+ Hits          363      374      +11     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review August 9, 2024 07:53
@gdalle gdalle merged commit 22b1834 into main Aug 9, 2024
@gdalle gdalle deleted the gd/interface branch August 9, 2024 07:58
@gdalle gdalle mentioned this pull request Aug 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant