Skip to content

More optimization for the decompression of the acyclic coloring#73

Merged
gdalle merged 7 commits intomainfrom
acyclic_decompression
Aug 13, 2024
Merged

More optimization for the decompression of the acyclic coloring#73
gdalle merged 7 commits intomainfrom
acyclic_decompression

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Aug 13, 2024

Related to #68

  • Efficient implementation of TreeSetColoringResult

@amontoison amontoison requested a review from gdalle August 13, 2024 03:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.21%. Comparing base (b6c38d9) to head (fd8d6fb).

Files Patch % Lines
src/decompression.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   98.37%   98.21%   -0.16%     
==========================================
  Files          10        9       -1     
  Lines         614      561      -53     
==========================================
- Hits          604      551      -53     
  Misses         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison amontoison force-pushed the acyclic_decompression branch from c396d68 to 5d00e30 Compare August 13, 2024 04:19
@amontoison
Copy link
Copy Markdown
Collaborator Author

@gdalle
The PR is ready.
We have the optimal structure for decompression and, in my opinion, the best method to compute it.
The only potential improvement could be to apply tricks to minimize dynamic allocations and reuse existing storage.
We can further optimize the code if, one day, someone encounters an issue with a very large graph.

@gdalle gdalle merged commit c3acf52 into main Aug 13, 2024
@gdalle gdalle deleted the acyclic_decompression branch August 13, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants