Skip to content

Allocation-free decompression in all cases#76

Merged
gdalle merged 1 commit intomainfrom
gd/perf
Aug 13, 2024
Merged

Allocation-free decompression in all cases#76
gdalle merged 1 commit intomainfrom
gd/perf

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Aug 13, 2024

  • Avoid findnz and directly use the SparseMatrixCSC structure of S to iterate over all nonzero (i, j) pairs in decompression
  • Un-skip the tests for alloc-free decompression into A::Matrix

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (baf5240) to head (2db82c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   98.21%   98.23%   +0.01%     
==========================================
  Files          10       10              
  Lines         617      622       +5     
==========================================
+ Hits          606      611       +5     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 4dc9e6e into main Aug 13, 2024
@gdalle gdalle deleted the gd/perf branch August 13, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant