Skip to content

Bringe coverage to 100% #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdalle merged 1 commit into from
Aug 14, 2024
Merged

Bringe coverage to 100% #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/examples.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function what_fig_41()
#! format: on
@assert M == transpose(M)
nonzeros(M) .= 1:length(nonzeros(M))
A = float.(sparse(Symmetric(M)))
A = sparse(Symmetric(M))
color = [
1, # 1. green
2, # 2. red
Expand Down Expand Up @@ -77,7 +77,7 @@ function what_fig_61()
#! format: on
@assert M == transpose(M)
nonzeros(M) .= 1:length(nonzeros(M))
A = float.(sparse(Symmetric(M)))
A = sparse(Symmetric(M))
color = [
1, # 1. red
2, # 2. blue
Expand Down Expand Up @@ -123,7 +123,7 @@ function efficient_fig_1()
#! format: on
@assert M == transpose(M)
nonzeros(M) .= 1:length(nonzeros(M))
A = float.(sparse(Symmetric(M)))
A = sparse(Symmetric(M))
color = [
1, # 1. red
2, # 2. cyan
Expand Down Expand Up @@ -171,7 +171,7 @@ function efficient_fig_4()
#! format: on
@assert M == transpose(M)
nonzeros(M) .= 1:length(nonzeros(M))
A = float.(sparse(Symmetric(M)))
A = sparse(Symmetric(M))
color = [
1, # 1. red
2, # 2. cyan
Expand Down
4 changes: 2 additions & 2 deletions src/result.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ function LinearSystemColoringResult(
(i < j) && push!(strict_upper_nonzero_inds, (i, j))
end

T = spzeros(Float64, n * C, length(strict_upper_nonzero_inds))
T = spzeros(float(R), n * C, length(strict_upper_nonzero_inds))
for (l, (i, j)) in enumerate(strict_upper_nonzero_inds)
ci = color[i]
cj = color[j]
Expand All @@ -382,7 +382,7 @@ function LinearSystemColoringResult(
end
T_factorization = factorize(T)

strict_upper_nonzeros_A = Vector{R}(undef, size(T, 2))
strict_upper_nonzeros_A = Vector{float(R)}(undef, size(T, 2))

return LinearSystemColoringResult(
S, color, group, strict_upper_nonzero_inds, strict_upper_nonzeros_A, T_factorization
Expand Down
8 changes: 4 additions & 4 deletions test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function test_coloring_decompression(
) where {structure,partition,decompression}
color_vec = Vector{Int}[]
@testset "$(typeof(A))" for A in matrix_versions(A0)
result = coloring(A, problem, algo; decompression_eltype=eltype(A))
result = coloring(A, problem, algo; decompression_eltype=Float64)
color = if partition == :column
column_colors(result)
elseif partition == :row
Expand Down Expand Up @@ -91,9 +91,9 @@ function test_coloring_decompression(

@testset "Linear system decompression" begin
if structure == :symmetric
linresult = LinearSystemColoringResult(sparse(A), color, eltype(A))
@test decompress(B, linresult) ≈ A0
@test decompress!(respectful_similar(A), B, linresult) ≈ A0
linresult = LinearSystemColoringResult(sparse(A), color, Float64)
@test decompress(float.(B), linresult) ≈ A0
@test decompress!(respectful_similar(float.(A)), float.(B), linresult) ≈ A0
end
end
end
Expand Down