Skip to content

Better sparsity pattern check#9

Merged
gdalle merged 2 commits intomainfrom
gd/decompression_error
May 24, 2024
Merged

Better sparsity pattern check#9
gdalle merged 2 commits intomainfrom
gd/decompression_error

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented May 24, 2024

Source

  • Add better sparsity pattern comparison by validating nzrange (rowvals still could differ)

Tests

  • Test exception thrown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (65fa107) to head (ba9cdeb).

Additional details and impacted files
@@             Coverage Diff             @@
##             main        #9      +/-   ##
===========================================
+ Coverage   99.06%   100.00%   +0.93%     
===========================================
  Files           7         7              
  Lines         215       229      +14     
===========================================
+ Hits          213       229      +16     
+ Misses          2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review May 24, 2024 15:18
@gdalle gdalle merged commit 2c5d35c into main May 24, 2024
@gdalle gdalle deleted the gd/decompression_error branch May 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant