Less hacky esc_sequence #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobaldassi
force-pushed
the
new_esc_seq
branch
from
1a7c5af to
9393bd3
Compare
carlobaldassi
force-pushed
the
new_esc_seq
branch
from
9393bd3 to
ff183b2
Compare
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work more generally and on all operating systems to get out of completion mode.
Fixes #204, hopefully #205 too. I cannot test it on Windows however.
@rabirabirara can you test this and confirm whether the above issues are fixed?
If it works, this supersedes #215.