Removing BlockArrays #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
See also #18 |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 98.27% 89.83% -8.44%
==========================================
Files 10 12 +2
Lines 348 610 +262
==========================================
+ Hits 342 548 +206
- Misses 6 62 +56
Continue to review full report at Codecov.
|
Collaborator
Author
|
With the new release of AbstractOperators test are now passing. |
Member
|
@nantonel please do, but tag it as v0.2 since this is not a bugfix, but a change in the algorithms interface (tuples are not allowed anymore). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockArrays are now completely removed: code is substantially simplified and more readable.
Notice that now we could think of making ProximalAlgorithms independent of AbstractOperators (but not in the tests).
In
utilities/tomove.jlfew line of codes to make ProximalOperators compatible with RecursiveArrayTools. These could be moved to ProximalOperators.(This PR is joint with AbstractOperators PR8)