Skip to content

Add rotate! and reflect! functions#283

Closed
amontoison wants to merge 2 commits intoJuliaGPU:masterfrom
amontoison:rot!
Closed

Add rotate! and reflect! functions#283
amontoison wants to merge 2 commits intoJuliaGPU:masterfrom
amontoison:rot!

Conversation

@amontoison
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread src/blas/highlevel.jl Outdated
Comment thread src/blas/highlevel.jl Outdated
Comment thread test/rocarray/blas.jl Outdated
Comment thread test/rocarray/blas.jl Outdated
@amontoison
Copy link
Copy Markdown
Member Author

amontoison commented Sep 13, 2022

@jpsamaroo
off topic: Do you know if it's possible to add a generic fallback for reflect! in GPUArrays.jl?
I don't know how to implement it without a kernel.

amontoison and others added 2 commits September 13, 2022 16:33
Co-authored-by: Julian Samaroo <jpsamaroo@gmail.com>
@pxl-th
Copy link
Copy Markdown
Member

pxl-th commented Sep 2, 2023

Superseded by #484

@pxl-th pxl-th closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants