Skip to content

blas: Improve error on missing rocBLAS#462

Merged
jpsamaroo merged 1 commit intomasterfrom
jps/deps-early-error
Aug 7, 2023
Merged

blas: Improve error on missing rocBLAS#462
jpsamaroo merged 1 commit intomasterfrom
jps/deps-early-error

Conversation

@jpsamaroo
Copy link
Copy Markdown
Member

Now:

julia> qr(A)
ERROR: ArgumentError: rocBLAS is not available
Stacktrace:
 [1] lib_state()
   @ AMDGPU.rocBLAS ~/.julia/dev/AMDGPU/src/blas/rocBLAS.jl:41
 [2] handle()
   @ AMDGPU.rocBLAS ~/.julia/dev/AMDGPU/src/blas/rocBLAS.jl:49
 [3] geqrf!(A::ROCMatrix{ComplexF64, AMDGPU.Runtime.Mem.HIPBuffer})
   @ AMDGPU.rocSOLVER ~/.julia/dev/AMDGPU/src/solver/highlevel.jl:13
 [4] qr!(A::ROCMatrix{ComplexF64, AMDGPU.Runtime.Mem.HIPBuffer})
   @ AMDGPU.rocSOLVER ~/.julia/dev/AMDGPU/src/solver/highlevel.jl:206
 [5] qr(::ROCMatrix{ComplexF64, AMDGPU.Runtime.Mem.HIPBuffer}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ LinearAlgebra ~/.julia/juliaup/julia-1.9.2+0.x64.linux.gnu/share/julia/stdlib/v1.9/LinearAlgebra/src/qr.jl:428
 [6] qr(::ROCMatrix{ComplexF64, AMDGPU.Runtime.Mem.HIPBuffer})
   @ LinearAlgebra ~/.julia/juliaup/julia-1.9.2+0.x64.linux.gnu/share/julia/stdlib/v1.9/LinearAlgebra/src/qr.jl:425
 [7] top-level scope
   @ REPL[6]:1

Fixes #461

@jpsamaroo jpsamaroo added bug Something isn't working blas labels Aug 7, 2023
@jpsamaroo jpsamaroo merged commit 05b46a4 into master Aug 7, 2023
@jpsamaroo jpsamaroo deleted the jps/deps-early-error branch August 7, 2023 17:31
@pxl-th
Copy link
Copy Markdown
Member

pxl-th commented Aug 7, 2023

Maybe instead of checking every time we access the library state, we should check only once in rocBLAS.create_handle method?

@jpsamaroo
Copy link
Copy Markdown
Member Author

Oops, yeah, that would have been better 😅 Thanks for fixing that and others!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blas bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected error: ccall requires compiler when using QR

2 participants