Support tuple dims in mapreduce_nd using CartesianIndices#83
Open
shreyas-omkar wants to merge 1 commit into
Open
Support tuple dims in mapreduce_nd using CartesianIndices#83shreyas-omkar wants to merge 1 commit into
shreyas-omkar wants to merge 1 commit into
Conversation
Member
Author
|
@maleadt and @christiangnrd, Please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support tuple
dimsinmapreduce_ndExtends
mapreduce/reduceto acceptdimsas aTuple{Vararg{Int}}in addition to a singleInt, matching the semantics ofBase.mapreduce.What changed
mapreduce_ndsignature updated todims::Union{Int, Tuple{Vararg{Int}}}CartesianIndices-based approach, splitting iteration intoRother(kept dims) andRreduce(reduced dims), mirroring the approach in GPUArrays.jl'svc/ka_mapreducedimbranchTesting
dims=(1,2),(1,3),(2,3),(1,2,3)on 3D arrays