Conversation
The previous fix used `esc(quote ... end)`, which made the generated code resolve `Adapt.adapt_structure` in the caller's module. This broke modules that do `using Adapt: @adapt_structure` (e.g. DataInterpolationsND) because `Adapt` itself is not bound there. Switch to value-interpolating the Adapt module directly via `$Adapt` (and `$$Adapt` to reach into the inner quote that runs at codegen time). The function-argument names `to` and `obj` are escaped explicitly so hygiene does not gensym them — that keeps them matching the literal `:to`/`:obj` symbols inside the inner quote. The resulting IR is unchanged (direct getfield + %new). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix used
esc(quote ... end), which made the generated code resolveAdapt.adapt_structurein the caller's module. This broke modules that dousing Adapt: @adapt_structure(e.g. DataInterpolationsND) becauseAdaptitself is not bound there.Switch to value-interpolating the Adapt module directly via
$Adapt(and$$Adaptto reach into the inner quote that runs at codegen time). The function-argument namestoandobjare escaped explicitly so hygiene does not gensym them — that keeps them matching the literal:to/:objsymbols inside the inner quote. The resulting IR is unchanged (direct getfield + %new).Fixes #108