Skip to content

Metal: drop integer call-site attributes when narrowing pointer args#826

Merged
maleadt merged 1 commit into
mainfrom
tb/fix
Jun 3, 2026
Merged

Metal: drop integer call-site attributes when narrowing pointer args#826
maleadt merged 1 commit into
mainfrom
tb/fix

Conversation

@maleadt
Copy link
Copy Markdown
Member

@maleadt maleadt commented Jun 3, 2026

The typed-pointer shim retargeted a Ptr argument's integer image to a pointer but left the call site's integer attributes (e.g. zeroext) in place, which LLVM rejects on a pointer. Crashed throwing-kernel codegen on Julia 1.10/1.11.

The typed-pointer shim retargeted a Ptr argument's integer image to a
pointer but left the call site's integer attributes (e.g. zeroext) in
place, which LLVM rejects on a pointer. Crashed throwing-kernel codegen
on Julia 1.10/1.11.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@maleadt maleadt merged commit 8bd3aa7 into main Jun 3, 2026
35 of 37 checks passed
@maleadt maleadt deleted the tb/fix branch June 3, 2026 07:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.02%. Comparing base (7b270bd) to head (a751d1b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   79.04%   79.02%   -0.02%     
==========================================
  Files          25       25              
  Lines        4586     4587       +1     
==========================================
  Hits         3625     3625              
- Misses        961      962       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant