Metal: Drive the downgrader here, lower intrinsics during mcgen.#829
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 79.30% 79.30%
=======================================
Files 25 25
Lines 4517 4542 +25
=======================================
+ Hits 3582 3602 +20
- Misses 935 940 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves some magic out of Metal.jl, and also makes it possible to request both the LLVM IR as produced by Julia, as well as the AIR one with intrinsics lowered to AIR-specific ones. We may want to do this for PTX too (i.e., do the LLVM -> NVVM lowering late, during
mcgen).This is breaking for Metal.jl, but I'll retro-cap it when registering.
EDIT: turns out I won't have to because of the compat added here.