Skip to content

Metal: Drive the downgrader here, lower intrinsics during mcgen.#829

Merged
maleadt merged 1 commit into
mainfrom
tb/metal_downgrader
Jun 4, 2026
Merged

Metal: Drive the downgrader here, lower intrinsics during mcgen.#829
maleadt merged 1 commit into
mainfrom
tb/metal_downgrader

Conversation

@maleadt
Copy link
Copy Markdown
Member

@maleadt maleadt commented Jun 4, 2026

Moves some magic out of Metal.jl, and also makes it possible to request both the LLVM IR as produced by Julia, as well as the AIR one with intrinsics lowered to AIR-specific ones. We may want to do this for PTX too (i.e., do the LLVM -> NVVM lowering late, during mcgen).

This is breaking for Metal.jl, but I'll retro-cap it when registering.
EDIT: turns out I won't have to because of the compat added here.

@maleadt maleadt merged commit 5e4c84f into main Jun 4, 2026
35 of 37 checks passed
@maleadt maleadt deleted the tb/metal_downgrader branch June 4, 2026 08:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.30%. Comparing base (5d88d3c) to head (af52be5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/metal.jl 91.66% 1 Missing ⚠️
src/utils.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files          25       25           
  Lines        4517     4542   +25     
=======================================
+ Hits         3582     3602   +20     
- Misses        935      940    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant