Conversation
Base.`^(::Union{Float16,Float32,Float64}, ::Int64)` widens Float32/16 through
Float64 (via `power_by_squaring`), which breaks on backends without FP64
support like oneAPI on some devices, and leaves a runtime `pown` call in the
generated code in all cases.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 12 12
Lines 745 745
=======================================
Hits 598 598
Misses 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nhz2
reviewed
Apr 15, 2026
| y == 1 && return x | ||
| y == 2 && return x * x | ||
| y == 3 && return x * x * x | ||
| x ^ (y % Int32) |
There was a problem hiding this comment.
Shouldn't this normally overflow to Inf instead of wrapping? Maybe replace y%Int32 with Float32(y)?
julia> 2.0^(Int64(2)^32 % Int32)
1.0
julia> 2.0^(Int64(2)^32)
Inf
Member
Author
There was a problem hiding this comment.
Yeah OK that's sloppy. Thanks; I'll create a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base.
^(::Union{Float16,Float32,Float64}, ::Int64)widens Float32/16 through Float64 (viapower_by_squaring), which breaks on backends without FP64 support like oneAPI on some devices, and leaves a runtimepowncall in the generated code in all cases.Needed for JuliaGPU/GPUArrays.jl#707