Skip to content

Conversation

@mikeingold
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (8e727e8) to head (3f1873a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   78.21%   78.21%           
=======================================
  Files           7        7           
  Lines         358      358           
=======================================
  Hits          280      280           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert
Copy link
Member

Could you also please put the compat entry of "julia" in Project.toml down as in https://github.com/mikeingold/MeshIntegrals.jl/pull/46/files? Then CompatHelper doesn't want to do that the next time

@mikeingold
Copy link
Collaborator Author

Oops, missed that change. Is there a reason why it prefers to have the "julia" entry on the final line? Looks otherwise unchanged.

@JoshuaLampert
Copy link
Member

I think it's a convention to have it as the final line (?)

@mikeingold mikeingold marked this pull request as ready for review August 17, 2024 13:04
@mikeingold mikeingold merged commit 59688fd into main Aug 17, 2024
@mikeingold mikeingold deleted the v49 branch August 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants