Skip to content

Use broadcast rules on 0.6 (fixes dot-operators depwarn)#71

Merged
timholy merged 1 commit intomasterfrom
teh/dots
Feb 16, 2017
Merged

Use broadcast rules on 0.6 (fixes dot-operators depwarn)#71
timholy merged 1 commit intomasterfrom
teh/dots

Conversation

@timholy
Copy link
Copy Markdown
Member

@timholy timholy commented Feb 14, 2017

This is a breaking change, because on Julia 0.6 the array eltype no longer "wins": the output is the same as what you'd get from adding the scalars. The package's behavior is now consistent with whatever the Julia version does for other "number" types.

This is a breaking change, because on Julia 0.6 the array eltype no longer "wins": the output is the same as what you'd get from adding the scalars.
@timholy
Copy link
Copy Markdown
Member Author

timholy commented Feb 14, 2017

Test failure on nightly is because it's behind julia master.

@timholy timholy merged commit 7f5a67b into master Feb 16, 2017
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #71 into master will decrease coverage by -0.24%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   64.68%   64.44%   -0.24%     
==========================================
  Files           1        2       +1     
  Lines         269      270       +1     
==========================================
  Hits          174      174              
- Misses         95       96       +1
Impacted Files Coverage Δ
src/ColorVectorSpace.jl 66.83% <57.14%> (+2.15%)
src/dots.jl 58.1% <58.1%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b086d...c644aa9. Read the comment docs.

@timholy timholy deleted the teh/dots branch February 16, 2017 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants