-
Notifications
You must be signed in to change notification settings - Fork 23
Bump requirements to julia-0.7 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
the removal of Compat seems to cause errors |
|
Took the freedom to fix the functionality relying on Compat. Luckily it was just vectorize_arg. Pretty sure that the |
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
===========================================
+ Coverage 85.71% 96.58% +10.86%
===========================================
Files 1 1
Lines 175 117 -58
===========================================
- Hits 150 113 -37
+ Misses 25 4 -21
Continue to review full report at Codecov.
|
|
any veto on a quick merge + tag?! @timholy |
|
It still has a heck of a lot of depwarns, and I was thinking we'd want to get rid of those first? I got rid of some in ColorTypes and more in my latest commit. But the new stdlib Statistics is going to wreak temporary havoc. We may need to wait for StatsBase to release a new version to really know if they are gone 😦. But I suppose we could tag now if this passes. |
|
Looks like 64bit windows is behind in the buildbots, but the minimum julia version should take care of that. All others passed. Because I'm reasonably confident that all the remaining depwarns need fixing outside this package, I'll merge. |
To trigger femtocleaner