Skip to content

Conversation

@timholy
Copy link
Member

@timholy timholy commented Jun 25, 2018

To trigger femtocleaner

@cormullion
Copy link
Member

the removal of Compat seems to cause errors

@SimonDanisch
Copy link
Member

Took the freedom to fix the functionality relying on Compat. Luckily it was just vectorize_arg. Pretty sure that the vectorize(1/2)_arg isn't needed anymore with broadcast! Tests pass locally when removing them, so if it was needed, it wasn't even receiving any test coverage.

@codecov-io
Copy link

codecov-io commented Jun 29, 2018

Codecov Report

Merging #87 into master will increase coverage by 10.86%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #87       +/-   ##
===========================================
+ Coverage   85.71%   96.58%   +10.86%     
===========================================
  Files           1        1               
  Lines         175      117       -58     
===========================================
- Hits          150      113       -37     
+ Misses         25        4       -21
Impacted Files Coverage Δ
src/ColorVectorSpace.jl 96.58% <100%> (+10.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae92d14...1104a12. Read the comment docs.

@SimonDanisch
Copy link
Member

any veto on a quick merge + tag?! @timholy

@SimonDanisch SimonDanisch mentioned this pull request Jun 29, 2018
4 tasks
@timholy
Copy link
Member Author

timholy commented Jun 29, 2018

It still has a heck of a lot of depwarns, and I was thinking we'd want to get rid of those first? I got rid of some in ColorTypes and more in my latest commit. But the new stdlib Statistics is going to wreak temporary havoc. We may need to wait for StatsBase to release a new version to really know if they are gone 😦.

But I suppose we could tag now if this passes.

@timholy
Copy link
Member Author

timholy commented Jun 29, 2018

Looks like 64bit windows is behind in the buildbots, but the minimum julia version should take care of that. All others passed. Because I'm reasonably confident that all the remaining depwarns need fixing outside this package, I'll merge.

@timholy timholy merged commit 72b6d04 into master Jun 29, 2018
@timholy timholy deleted the teh/0.7 branch June 29, 2018 20:25
@timholy timholy mentioned this pull request Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants