Fix unreachable on nightly #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianna
approved these changes
Feb 9, 2024
Member
ianna
left a comment
ianna
left a comment
There was a problem hiding this comment.
@Moelf - Thank you for fixing the bug! I approve and merge this PR (though I do not understand what is being changed in 1.11.* nightly with respect to 1.9 as looking at Julia's documentation: "The default behavior in Julia when types are omitted is to allow values to be of any type.")
Member
Author
|
I still think this is a breaking change on Julia's end, so it would be nice to have a separate reproducer and open an issue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #66