-
Notifications
You must be signed in to change notification settings - Fork 162
Add Docker image and example using docker-compose #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
commented
Feb 1, 2019
sapir
reviewed
Feb 1, 2019
This follows all the intructions for llvm and makes it possilble to start making reproducible builds
This makes it nice for building an image based on the current repo, not the latest HEAD
2c301b9 to
27d29e2
Compare
vtjnash
reviewed
Feb 16, 2019
Dockerfile
Outdated
| unzip /root/ninja-linux.zip; \ | ||
| rm /root/ninja-linux.zip; \ | ||
| mv /root/ninja /bin/ninja; \ | ||
| chmod +x /bin/ninja; \ |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use apt for ninja too?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
vtjnash
reviewed
Mar 11, 2019
vtjnash
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strings together all the documentation for setup, building, testing of llvm-cbe and how to use it. Using Docker will make llvm-cbe more portable and easier for folks to use.