Skip to content

Conversation

@davidanthoff
Copy link
Contributor

This will enable saving of vega and vega-lite files to HTML.

I've added a custom MIME type called application/vnd.julia.fileio.htmlfile for situations where a type does not want to provide a show method for text/html, but still wants to support saving as HTML files (this is a case I need to support in VegaLite.jl).

@timholy
Copy link
Member

timholy commented Feb 6, 2020

Willing to merge this in principle (this is an area I don't know a lot about), but the tests are currently failing. Does it just need to be retriggered or is there something missing here?

@davidanthoff
Copy link
Contributor Author

Ok, tests are fixed now!

@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #250 into master will decrease coverage by 0.13%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   76.22%   76.08%   -0.14%     
==========================================
  Files           8        8              
  Lines         408      414       +6     
==========================================
+ Hits          311      315       +4     
- Misses         97       99       +2
Impacted Files Coverage Δ
src/registry.jl 92.64% <ø> (ø) ⬆️
src/mimesave.jl 72.72% <66.66%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5577f...d47ff4b. Read the comment docs.

@timholy timholy merged commit fa96012 into JuliaIO:master Feb 8, 2020
@davidanthoff davidanthoff deleted the html branch February 8, 2020 15:39
@davidanthoff
Copy link
Contributor Author

Thanks! Could you also tag a release?

@timholy
Copy link
Member

timholy commented Feb 8, 2020

JuliaRegistries/General#9078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants