Add new magic bytes for JLD2 #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my opinion it is unlikely for JLD2 to ever become a drop-in replacement for JLD. Definitely not with full backwards compatibility - so it makes sense for the magic bytes to differ by more than just a version number. The changes over at JLD2 are here JuliaIO/JLD2.jl#213
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 76.31% 76.31%
=======================================
Files 8 8
Lines 418 418
=======================================
Hits 319 319
Misses 99 99
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion it is unlikely for JLD2 to ever become a drop-in replacement for JLD.
Definitely not with full backwards compatibility - so it makes sense for the magic bytes to differ by more than just a version number.
The changes over at JLD2 are here JuliaIO/JLD2.jl#213