Skip to content

Conversation

@timholy
Copy link
Member

@timholy timholy commented Aug 27, 2020

No huge impacts here, but the new bodyfunction on Julia 1.6 lets us shave off a few tens of milliseconds on first use. Nothing amazing but worth having.

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #273 into master will decrease coverage by 3.06%.
The diff coverage is 10.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   76.42%   73.36%   -3.07%     
==========================================
  Files           8        8              
  Lines         420      443      +23     
==========================================
+ Hits          321      325       +4     
- Misses         99      118      +19     
Impacted Files Coverage Δ
src/precompile.jl 0.00% <0.00%> (ø)
src/loadsave.jl 87.34% <100.00%> (+0.32%) ⬆️
src/types.jl 65.00% <100.00%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da531c...e517e9f. Read the comment docs.

Formerly we were compiling 77 instances of this function!
@timholy timholy merged commit 9826852 into master Aug 27, 2020
@timholy timholy deleted the teh/more_precomiples branch August 27, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants