new low_speed_limit and low_speed_time options
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The second commit reverts my change to the version number in Project.toml. I used that for testing purposes, but of course versioning should be up to the project maintainer :) |
Author
|
This is relevant here also: JuliaLang/Downloads.jl#193 |
tanmaykm
reviewed
Jul 15, 2022
| else | ||
| timeout = timeout ≤ typemax(Clong) ? round(Clong, timeout) : Clong(0) | ||
| Curl.setopt(easy, CURLOPT_CONNECTTIMEOUT, timeout) | ||
| Curl.setopt(easy, CURLOPT_CONNECTTIMEOUT, Clong(0)) |
Member
There was a problem hiding this comment.
This would disregard the specified timeout value. Was this intentional?
Ah, didn't notice the explanation here. Yes, this looks correct.
Member
|
@manuelbb-upb are there any more changes to be done here? If not, maybe mark it ready? |
Member
|
Closing, as these are most likely not needed. Ref: #22 (comment) |
tanmaykm
added a commit
that referenced
this pull request
Jul 20, 2022
This adds an upper limit to the connect timeout value that can be specified, to limit it to `typemax(Clong) ÷ 1000`. An `ArgumentError` is thrown if the value is out of range. This matches what libcurl expects [here](https://github.com/curl/curl/blob/4a8f6869db3a4ba7cd1bcb153c3d5b4298728afa/lib/setopt.c#L1376). Originally reported at JuliaLang/Downloads.jl#193 and #23.
tanmaykm
added a commit
that referenced
this pull request
Jul 20, 2022
This adds an upper limit to the connect timeout value that can be specified, to limit it to `typemax(Clong) ÷ 1000`. An `ArgumentError` is thrown if the value is out of range. This matches what libcurl expects [here](https://github.com/curl/curl/blob/4a8f6869db3a4ba7cd1bcb153c3d5b4298728afa/lib/setopt.c#L1376). Originally reported at JuliaLang/Downloads.jl#193 and #23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I came up with to circumvent issue #22
Both options default to 0 in accordance with the corresponding Curl options.