[WIP]Add flow evaluation functions by Deepank308 · Pull Request #19 · JuliaImages/ImageTracking.jl

Deepank308 · 2019-03-09T10:36:57Z

Added end point error evaluation function. Currently, the function evaluates error iff ground truth flow is also provided as an array.

Deepank308 · 2019-03-09T10:55:14Z

@zygmuntszpak, I was searching for the standard methods for evaluations, I found out this. My doubt is : Is it a convention to use .flo file, in a standard widely accepted format(as in here), to store the ground truth flow vector or a user may directly pass the ground truth flow vector? Because I am not able to read from these .flo file in Julia.

I also referred to OpenCV contrib repository for some idea, they also end up using the .flo file for ground truth flow in the above specified format. So, I also tried to read these .flo file in Julia but couldn't, however in C++ I could.

I am still trying to successfully read the .flo files, once it's done will add a commit for the reading function.

codecov · 2019-03-09T11:29:57Z

Codecov Report

Merging #19 into master will decrease coverage by 3.17%.
The diff coverage is 50.7%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage    64.8%   61.62%   -3.18%     
==========================================
  Files           7        7              
  Lines         375      443      +68     
==========================================
+ Hits          243      273      +30     
- Misses        132      170      +38

Impacted Files	Coverage Δ
src/ImageTracking.jl	`100% <100%> (ø)`	⬆️
src/utility.jl	`46.57% <48.52%> (-40.93%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83b91f...be59eb4. Read the comment docs.

codecov · 2019-03-09T11:29:57Z

Codecov Report

Merging #19 into master will decrease coverage by 1.84%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage    64.8%   62.95%   -1.85%     
==========================================
  Files           7        7              
  Lines         375      386      +11     
==========================================
  Hits          243      243              
- Misses        132      143      +11

Impacted Files	Coverage Δ
src/ImageTracking.jl	`100% <ø> (ø)`	⬆️
src/utility.jl	`36.84% <0%> (-50.66%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83b91f...71af507. Read the comment docs.

Deepank308 · 2019-03-12T11:04:26Z

@zygmuntszpak I have put the error evaluation functions in the same utility.jl. Or, should I keep seperately the flow visualization function and the error evaluation functions?

zygmuntszpak · 2019-03-13T08:22:59Z

@zygmuntszpak I have put the error evaluation functions in the same utility.jl. Or, should I keep seperately the flow visualization function and the error evaluation functions?

I reckon you can put it in utility.jl for now.

With regard to the ground truth, as far as I can tell we should allow the user to specify the ground truth flow as Array{SVector{2, Float64}, 2} and then work on a parser that can read the .flo file and convert it to Array{SVector{2, Float64}, 2}.

Deepank308 · 2019-03-16T15:15:01Z

@zygmuntszpak I haven't added the test function yet. Once, I am able to parse the .flo files I will add the test.

Deepank308 · 2019-03-23T11:48:35Z

The last commit adds following :

.flo file reading function
demo for error evaluation
test for error evaluation
cleans demo_franeback.jl - moving the error evaluation part to new demo_error_evaluation.jl file.

I have changed the name of evaluate_error function to evaluate_flow_error because there is an identically named function under test/franeback.jl and test/lucas_kanade.jl which was throwing error while running the tests.

@zygmuntszpak please review and suggest changes.
Thank you

Deepank308 · 2019-03-23T11:50:29Z

I'm really sorry for being so late! I was drafting my GSoC proposal.

zygmuntszpak · 2019-04-12T08:11:49Z

I wonder if we shouldn't define an AbstractCoordinateConvention and then have RasterConvention and CartesianConvention as subtypes instead of using strings x_y and row_col. For example, we currently use strings to indicate the convention convention="row_col".

Deepank308 · 2019-04-16T06:30:20Z

@zygmuntszpak done

zygmuntszpak

I had a moment to study the code more carefully and have a few more suggestions. After this, I think we can go ahead and merge. Thank you for your patience and effort.

zygmuntszpak · 2019-04-16T23:54:53Z

Are the tests passing for you locally? I'm not sure why all of the builds have failed on Travis and Appveyor.

Deepank308 · 2019-04-17T03:29:27Z

What I think the error might be is, ImageTracking is not a part of the registered packages under Julia(at least it is not mentioned here). So, while testing it is throwing some error. The Project.toml doesn't has any name field for the package as in here.

zygmuntszpak · 2019-04-17T04:08:29Z

Ok, can you confirm that the tests pass on your machine? If so, then I will go ahead and merge and then work on a separate pull-request to register this package etc. I just want us to be reasonably confident that we don't commit broken code to the master branch.

Deepank308 · 2019-04-17T04:10:21Z

Yes, the tests are passing on my local machine.

johnnychen94 · 2019-04-17T06:25:56Z

@@ -0,0 +1,21 @@
+[[Libdl]]


If I make it right, generally, we don't provide Manifest.toml in the repo
the old julia/CI system uses REQUIRE, ~~but in most cases we still keep it to keep track of Project.toml~~
the new julia/CI system uses Project.toml

johnnychen94 · 2019-04-17T06:33:16Z

@@ -0,0 +1,2 @@
+[deps]


The workflow to generate Project.toml is:

]generate ImageTracking

add packages required for this package

add packages required in test stage

there'll be Project.toml and Manifest.toml generated

create a [extra] section, and move packages required by test stage only in [deps] section to this section

create a [targets] section, and write in format STAGENAME = ["PKG1", "PKG2"], e.g., test = ["Test"]

delete the Manifest.toml and upload Project.toml

see https://julialang.github.io/Pkg.jl/v1/creating-packages/ for more information

[WIP]Add flow evaluation functions

71af507

Add angular error function

4bc9111

zygmuntszpak reviewed Mar 13, 2019

View reviewed changes

Comment thread src/utility.jl Outdated

Comment thread src/utility.jl Outdated

Comment thread src/utility.jl Outdated

Comment thread src/utility.jl Outdated

Comment thread src/utility.jl Outdated

Add statistics calculation finction

d33cc5d

Add read_flow_file function and test for error evaluation function

7509f34

Deepank308 changed the title ~~[WIP]Add flow evaluation functions~~ Add flow evaluation functions Mar 23, 2019

Deepank308 changed the title ~~Add flow evaluation functions~~ [WIP]Add flow evaluation functions Mar 23, 2019

Add Abstract coordinate convention

05284fd

zygmuntszpak requested changes Apr 16, 2019

View reviewed changes

Satisfies Changes requested

70f187a

zygmuntszpak reviewed Apr 16, 2019

View reviewed changes

Comment thread src/utility.jl Outdated

Minor changes

be59eb4

zygmuntszpak merged commit 7e329ec into JuliaImages:master Apr 17, 2019

johnnychen94 reviewed Apr 17, 2019

View reviewed changes

Conversation

Deepank308 commented Mar 9, 2019

Uh oh!

Deepank308 commented Mar 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov Bot commented Mar 9, 2019

Codecov Report

Uh oh!

Deepank308 commented Mar 12, 2019

Uh oh!

zygmuntszpak commented Mar 13, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Deepank308 commented Mar 16, 2019

Uh oh!

Deepank308 commented Mar 23, 2019

Uh oh!

Deepank308 commented Mar 23, 2019

Uh oh!

zygmuntszpak commented Apr 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Deepank308 commented Apr 16, 2019

Uh oh!

zygmuntszpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zygmuntszpak commented Apr 16, 2019

Uh oh!

Deepank308 commented Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zygmuntszpak commented Apr 17, 2019

Uh oh!

Deepank308 commented Apr 17, 2019

Uh oh!

johnnychen94 Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnnychen94 Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Deepank308 commented Mar 9, 2019 •

edited

Loading

codecov Bot commented Mar 9, 2019 •

edited

Loading

zygmuntszpak commented Apr 12, 2019 •

edited

Loading

Deepank308 commented Apr 17, 2019 •

edited

Loading

johnnychen94 Apr 17, 2019 •

edited

Loading

johnnychen94 Apr 17, 2019 •

edited

Loading