Skip to content

Update README#26

Merged
zygmuntszpak merged 3 commits intoJuliaImages:masterfrom
vchuravy:vc/update
Oct 1, 2020
Merged

Update README#26
zygmuntszpak merged 3 commits intoJuliaImages:masterfrom
vchuravy:vc/update

Conversation

@vchuravy
Copy link
Copy Markdown
Contributor

@vchuravy vchuravy commented Sep 30, 2020

I would be interested in seeing ImageTracking tagged and registered. When trying it out earlier today I noticed that the README was quite directly runnable.

@vchuravy
Copy link
Copy Markdown
Contributor Author

@zygmuntszpak Given #25 (comment)

would it be okay to register the package?

@zygmuntszpak zygmuntszpak merged commit 502f315 into JuliaImages:master Oct 1, 2020
@zygmuntszpak
Copy link
Copy Markdown
Member

Absolutely. Thank you very much for getting it into the right state.

Comment thread Project.toml
Interpolations = ">= 0.7.3"
StaticArrays = ">= 0.7.0"
julia = "1"
julia = "1.3"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to revert this to julia = "1.0" as I don't see any hard requirements not compatible to Julia 1.0.

We have plans to switch to julia = "1.6" when that's released. JuliaImages/Images.jl#824 (comment)

Comment thread test/Project.toml
@@ -0,0 +1,10 @@
[deps]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was unstable when I read the docs.

https://julialang.github.io/Pkg.jl/v1/creating-packages/#Test-specific-dependencies-in-Julia-1.2-and-above-1
The exact interaction between Project.toml, test/Project.toml and their corresponding Manifest.tomls are not fully worked out, and may be subject to change in future versions. The old method of adding test-specific dependencies, described in the next section, will therefore be supported throughout all Julia 1.X releases.

But yeah, it works and works now.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I get it, this requires Julia 1.2.

I'll revert this, too. Just to keep Julia 1.0 compat. (Though it might be no one using it 😢 )

Comment thread README.md
#Technology. May 2009. =#
img1 = load("demo/table1.jpg")
img2 = load("demo/table2.jpg")
demo = joinpath(dirname(pathof(ImageTracking)), "..", "demo")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, a simpler version is possible in Julia 1.5: joinpath(pkgdir(ImageTracking), "demo")

@vchuravy vchuravy deleted the vc/update branch October 5, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants