Transcode strings to UTF-16 before passing them to MATLAB #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
reviewed
Nov 6, 2016
| mx = MxArray(pm) | ||
| ccall(:memcpy, Ptr{Void}, (Ptr{Void}, Ptr{Void}, UInt), data_ptr(mx), utf16string, | ||
| length(utf16string)*sizeof(UInt16)) | ||
| mx |
Collaborator
There was a problem hiding this comment.
return mx (trying to be consistent)
Member
Author
There was a problem hiding this comment.
Maybe, but not exactly consistent elsewhere in the file.
simonster
commented
Nov 6, 2016
|
|
||
| # char arrays and string | ||
|
|
||
| function mxarray(s::String) |
simonster
commented
Nov 6, 2016
| pm = ccall(_mx_create_string, Ptr{Void}, (Ptr{UInt8},), s) | ||
| MxArray(pm) | ||
| utf16string = transcode(UInt16, s) | ||
| pm = ccall(_mx_create_char_array, Ptr{Void}, (mwSize, Ptr{mwSize},), 2, |
Member
Author
There was a problem hiding this comment.
ptr is not actually so clear, since this is a Ptr{Void} to the MATLAB object and not the pointer to the data. pm is the variable name used by the other functions like this in the file.
simonster
commented
Nov 6, 2016
| pm = ccall(_mx_create_char_array, Ptr{Void}, (mwSize, Ptr{mwSize},), 2, | ||
| _dims_to_mwSize((1, length(utf16string)))) | ||
| mx = MxArray(pm) | ||
| ccall(:memcpy, Ptr{Void}, (Ptr{Void}, Ptr{Void}, UInt), data_ptr(mx), utf16string, |
Member
Author
There was a problem hiding this comment.
The convention is usually "try to adhere to a 92 character line length limit"
musm
requested changes
Nov 6, 2016
| function mxarray(s::String) | ||
| pm = ccall(_mx_create_string, Ptr{Void}, (Ptr{UInt8},), s) | ||
| MxArray(pm) | ||
| utf16string = transcode(UInt16, s) |
Collaborator
There was a problem hiding this comment.
should prolly use mxChar here
| _dims_to_mwSize((1, length(utf16string)))) | ||
| mx = MxArray(pm) | ||
| ccall(:memcpy, Ptr{Void}, (Ptr{Void}, Ptr{Void}, UInt), data_ptr(mx), utf16string, | ||
| length(utf16string)*sizeof(UInt16)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes test from #78, which passes since we transcode the strings properly.