Fix the message in create_sysimg_object_file to correctly say "incremental" or "nonincremental"
#694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emental" or "nonincremental"
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 93.61% 93.63% +0.01%
==========================================
Files 2 2
Lines 470 471 +1
==========================================
+ Hits 440 441 +1
Misses 30 30
Continue to review full report at Codecov.
|
Member
Author
|
Bump @KristofferC |
KristofferC
reviewed
Jun 7, 2022
src/PackageCompiler.jl
Outdated
| --sysimage=$base_sysimage --project=$project --output-o=$(object_file) $outputo_file` | ||
| @debug "running $cmd" | ||
| spinner = TerminalSpinners.Spinner(msg = "PackageCompiler: compiling incremental system image") | ||
| if incremental |
Member
There was a problem hiding this comment.
I would write this as non = incremental ? "" : "non"
KristofferC
approved these changes
Jun 7, 2022
Member
|
Sorry for slow review, missed this in my notifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.