Skip to content

Conversation

@malmaud
Copy link
Contributor

@malmaud malmaud commented Jan 26, 2017

No description provided.

@tkelman
Copy link
Contributor

tkelman commented Jan 26, 2017

should also mention what sig is for

@malmaud
Copy link
Contributor Author

malmaud commented Jan 26, 2017

I'm actually unclear myself on why you would use it in this context

@tkelman
Copy link
Contributor

tkelman commented Jan 26, 2017

@kshyatt kshyatt added the docs This change adds or pertains to documentation label Jan 27, 2017
@MichaelHatherly
Copy link
Member

Passing sig should allow for returning different docs for ?x(1) and ?x(1.0), currently it seems there's a bug in ? mode preventing that from working though.

Probably not hugely important to have for PyCall for example, but I figured it would be best to make "dynamic" docs behave as closely to "normal" ones as possible.

@malmaud
Copy link
Contributor Author

malmaud commented Jan 27, 2017

Ya, that's what I thought initially and then got confused when ?x(1) didn't work. The manual probably shouldn't mention the sig stuff while it isn't actually working.

@kshyatt
Copy link
Member

kshyatt commented Jan 27, 2017

AV failure is in pkg, unrelated. Going to press the pretty button since this is Approved.

@kshyatt kshyatt merged commit 9605bbb into master Jan 27, 2017
@kshyatt kshyatt deleted the jmm/doc_manual branch January 27, 2017 19:30
@tkelman
Copy link
Contributor

tkelman commented Jan 27, 2017

currently it seems there's a bug in ? mode preventing that from working though.

That needs an issue - #20301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants