svd for Adjoint and Transpose #27916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
approved these changes
Jul 3, 2018
| @test_throws ErrorException usv.Z | ||
| b = rand(eltya,n) | ||
| @test usv\b ≈ transpose(a)\b | ||
| end |
Member
There was a problem hiding this comment.
I would think that the most obvious tests here would be these:
svd(a').U == svd(a).V
svd(a').S == svd(a).S
svd(a').V == svd(a).UIs there some reason not to test this directly? I realize that the precise U and V matrices are not well defined in many cases but it seems unlikely that this will ever break in this case, no?
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/LinearAlgebra.jl#523.