fix #29828, make use of TypeError more consistent#30272
Merged
JeffBezanson merged 1 commit intomasterfrom Dec 6, 2018
Merged
Conversation
JeffBezanson
added
error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventually the
funcfield ofTypeErrorshould be renamed or removed. We basically only need one field (a description of where the problem is), but it's inconvenient for the run time system to form new strings when throwing an error. However we could do whatjl_errorfdoes and format a string, thereby only needing one string field inTypeError. For now I went with something less disruptive.fix #29828