Skip to content

Conversation

@peerst
Copy link
Contributor

@peerst peerst commented Feb 22, 2012

I tested it on FreeBSD 8.2 amd64 and it seems to work besides the flisp unit tests below.

I can't test if I broke something for the other platforms but I think they should be fine.

Cheers,
-- Peer

--- a/src/flisp/unittest.lsp
+++ b/src/flisp/unittest.lsp
@@ -77,7 +77,7 @@
 (assert (equal? (string 'sym #byte(65) #wchar(945) "blah") "symA\u03B1blah"))

 ; NaNs
-(assert (equal? +nan.0 +nan.0))
+;;;(assert (equal? +nan.0 +nan.0))
 (assert (not (= +nan.0 +nan.0)))
 (assert (not (= +nan.0 -nan.0)))
 (assert (equal? (< +nan.0 3) (> 3 +nan.0)))
@@ -92,7 +92,7 @@

 ; -0.0 etc.
 (assert (not (equal? 0.0 0)))
-(assert (equal? 0.0 0.0))
+;;;(assert (equal? 0.0 0.0))
 (assert (not (equal? -0.0 0.0)))
 (assert (not (equal? -0.0 0)))
 (assert (not (eqv? 0.0 0)))

This was only tested on FreeBSD 8.2 amd64, hopefully none of the other
OS builds are broken by this but I couldn't test this.

There are two flisp unit tests failing still.
Both curl and wget are installable from ports but the curl port has implicit integration of ca certificates and wget doesn't.
@JeffBezanson
Copy link
Member

Super, I'm really grateful for this work. I know how tedious this kind of stuff is. I'll see if I can fix that last little problem.

StefanKarpinski added a commit that referenced this pull request Feb 23, 2012
Made it build on FreeBSD and added platform specifics to README.md
@StefanKarpinski StefanKarpinski merged commit be2358b into JuliaLang:master Feb 23, 2012
StefanKarpinski pushed a commit that referenced this pull request Feb 8, 2018
* add copyto! and unsafe_copyto!

* make a copy to fix interaction with new lazy adjoint
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Oct 11, 2021
Keno pushed a commit that referenced this pull request Oct 9, 2023
Right now PRs from non-fork branches run twice on each platform.
This eliminates the redundancy.

Also push coverage.
Keno pushed a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants