Skip to content

Conversation

@carlobaldassi
Copy link
Member

A couple of trivial commits:

  • Fix the case in which one tries to append/prepend a Vector to itself, by making a copy before growing. It could probably be handled more efficiently, but at least this avoids the error.
  • Relax the type signature and allow a generic AbstractVector to be appended/preprended; I don't see anything against this, but I'm not sure of why it was restricted originally; in any case, the two functions has a different signature for the second argument, which seems wrong.

@JeffBezanson
Copy link
Member

Thanks for catching this. I'm going to fix it in a way that hopefully performs better.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a72b1ff on carlobaldassi:app_prep into * on JuliaLang:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants