Skip to content

Small adjustments to apprend!/preprend! #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Small adjustments to apprend!/preprend! #4627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9928aed
Fix append!(x,x) and prepend!(x,x)
carlobaldassi Oct 25, 2013
a72b1ff
Allow {ap,pre}pending AbstractVectors to Arrays
carlobaldassi Oct 25, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions base/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,21 +668,23 @@ function push!(a::Array{Any,1}, item::ANY)
return a
end

function append!{T}(a::Array{T,1}, items::Vector)
function append!{T}(a::Array{T,1}, items::AbstractVector)
if is(T,None)
error(_grow_none_errmsg)
end
n = length(items)
a === items && (items = copy(items))
ccall(:jl_array_grow_end, Void, (Any, Uint), a, n)
a[end-n+1:end] = items
return a
end

function prepend!{T}(a::Array{T,1}, items::Array{T,1})
function prepend!{T}(a::Array{T,1}, items::AbstractVector)
if is(T,None)
error(_grow_none_errmsg)
end
n = length(items)
a === items && (items = copy(items))
ccall(:jl_array_grow_beg, Void, (Any, Uint), a, n)
a[1:n] = items
return a
Expand Down