use iszero in isinteger(::AbstractFloat) #55276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
approved these changes
Jul 27, 2024
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
It shouldn't make any difference with any of the built-in floating-point types
It may be marginally faster for BigFloat since it has a specialised iszero method not to run a ccall:
Line 1062 in 8a7e23d
Bug regardless of the magnitude of the speedup for BigFloat, the change looks good to me.
Seelengrab
reviewed
Jul 27, 2024
Co-authored-by: Sukera <11753998+Seelengrab@users.noreply.github.com>
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
This is a very slight tweak to the implementation of `isinteger(::AbstractFloat)` to use `iszero` rather than `== 0`. It shouldn't make any difference with any of the built-in floating-point types, but `iszero` might conceivably be faster for some user-defined types. I also added a comment to indicate why it's using `iszero(x - trunc(x))` rather than `x == trunc(x)` (due to non-finite values); this code dates back to JuliaLang#14569 in Julia 0.5. --------- Co-authored-by: Sukera <11753998+Seelengrab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very slight tweak to the implementation of
isinteger(::AbstractFloat)to useiszerorather than== 0. It shouldn't make any difference with any of the built-in floating-point types, butiszeromight conceivably be faster for some user-defined types.I also added a comment to indicate why it's using
iszero(x - trunc(x))rather thanx == trunc(x)(due to non-finite values); this code dates back to #14569 in Julia 0.5.