[LateLowerGC] Fix typo sret handling so we properly handle selects in the worklist #57741
+87
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
added
embarrassing-bugfix
giordano
reviewed
Mar 12, 2025
| #include "llvm-pass-helpers.h" | ||
| #include <map> | ||
| #include <string> | ||
| #include <optional> |
Member
There was a problem hiding this comment.
Should this include be in src/llvm-late-gc-lowering.cpp rather than here? I don't see uses of optional in this file.
Member
Author
There was a problem hiding this comment.
I was just following the pattern where that pass doesn't include any of it's own headers
vtjnash
approved these changes
Mar 12, 2025
topolarity
reviewed
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57737