Skip to content

Conversation

@mortenpi
Copy link
Contributor

@inkydragon inkydragon added docsystem The documentation building system bugfix This change fixes an existing bug labels May 15, 2025
Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanButterworth IanButterworth merged commit d54f9b6 into JuliaLang:master May 15, 2025
7 checks passed
@IanButterworth
Copy link
Member

Seems like this might still have problems?
https://buildkite.com/julialang/julia-master/builds/47565#0196d414-fd22-4ea3-9b17-09ae92598447/855-1165


┌ Error: Failed to push:
--
  | │   exception =
  | │    MethodError: no method matching postprocess_before_push(::Versions; subfolder::String, devurl::String, deploy_dir::String, dirname::String)
  | │    The function `postprocess_before_push` exists, but no method is defined for this combination of argument types.
  | │
  | │    Closest candidates are:
  | │      postprocess_before_push(::Nothing; subfolder, devurl, deploy_dir, dirname)
  | │       @ Documenter /cache/build/builder-amdci5-4/julialang/julia-master/doc/deps/packages/Documenter/N1Yg1/src/deploydocs.jl:525
  | │      postprocess_before_push(::AbstractVector; subfolder, devurl, deploy_dir, dirname)
  | │       @ Documenter /cache/build/builder-amdci5-4/julialang/julia-master/doc/deps/packages/Documenter/N1Yg1/src/deploydocs.jl:532
  | │
  | │    Stacktrace:
  | │      [1] (::Documenter.var"#git_commands#122"{String, String, SubString{String}, Nothing, String, Versions, Bool, String, String, String})(sshconfig::Nothing)
  | │        @ Documenter /cache/build/builder-amdci5-4/julialang/julia-master/doc/deps/packages/Documenter/N1Yg1/src/deploydocs.jl:428
  | │      [2] (::Documenter.var"#git_commands#122"{String, String, SubString{String}, Nothing, String, Versions, Bool, String, String, String})()
  | │        @ Documenter /cache/build/builder-amdci5-4/julialang/julia-master/doc/deps/packages/Documenter/N1Yg1/src/deploydocs.jl:382
  | │      [3] withenv(::Documenter.var"#git_commands#122"{String, String, SubString{String}, Nothing, String, Versions, Bool, String, String, String}, ::Pair{String, Nothing}, ::Vararg{Pair{String, Nothing}})
  | │        @ Base ./env.jl:265
  | │      [4] #129
  | │        @ /cache/build/builder-amdci5-4/julialang/julia-master/doc/deps/packages/Documenter/N1Yg1/src/deploydocs.jl:509 [inlined]
  | │      [5] cd(f::Documenter.var"#129#130", dir::String)
  | │        @ Base.Filesystem ./file.jl:112
  | │      [6] git_push(root::String, temp::String, repo::String; branch::String, dirname::String, target::String, sha::SubString{String}, cname::Nothing, devurl::String, versions::Versions, forcepush::Bool, deploy_config::BuildBotConfig, subfolder::String, is_preview::Bool, archive::String)
  | │        @ Documenter /cache/build/builder-amdci5-4/julialang/julia-master/doc/deps/packages/Documenter/N1Yg1/src/deploydocs.jl:509
  | │      [7] (::Documenter.var"#112#113"{SubString{String}, String, String, String, String, Nothing, String, Versions, Bool, BuildBotConfig, String, Bool, String})(temp::String)
  | │        @ Documenter /cache/build/builder-amdci5-4/julialang/julia-master/doc/deps/packages/Documenter/N1Yg1/src/deploydocs.jl:303
  | │      [8] mktempdir(fn::Documenter.var"#112#113"{SubString{String}, String, String, String, String, Nothing, String, Versions, Bool, BuildBotConfig, String, Bool, String}, parent::String; prefix::String)


@mortenpi
Copy link
Contributor Author

Hopefully will be properly fixed with #58431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This change fixes an existing bug docsystem The documentation building system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants