loading: Clamp Julia syntax version from Manifest as well #60275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading `syntax.julia_version` from a manifest entry, the value was used directly without being clamped to the minimum supported syntax version (NON_VERSIONED_SYNTAX = v"1.13"). This caused packages with manifests containing low syntax versions (e.g., v"1.0" from compat declarations like `julia = "1"`) to fail parsing with errors like "import ... as not supported in Julia version 1.0 < 1.6". The fix applies the same clamping logic that already exists in `project_get_syntax_version` to the manifest loading path in `explicit_manifest_entry_load_spec`. Fixes #60273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really a Pkg bug, where I forgot to implement the clamping when generating the manifest (and will submit a PR), but since we clamp and override when loading from a Project.toml, it seems reasonable to do the same for Manifest.toml. We never want to use a syntax version less than 1.13, so cut off that path as well, without assuming that Pkg.jl gets it right (too much manual editing of Manifest files happening with AI assistants).
Fixes #60273
Written by Claude.