Value-parameterised annotations and Face primacy #60527
Draft
+332
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecosaur
force-pushed
the
val-param-annot-faces
branch
12 times, most recently
from
04651e1 to
bce32f4
Compare
tecosaur
added
strings
TODO: Elaborate
tecosaur
force-pushed
the
val-param-annot-faces
branch
from
bce32f4 to
a5e0e17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a large effort to overhaul StyledStrings to address the major pain points that have come up since the initial design/implementation.
This work adds value-parameterisation to annotations, making static compilation more viable, replaces symbol-based face naming with a form of hybrid face-interning (
face""), overhauls thestyled""macro AST generation, adds face namespacing, and includes light/dark theming work mentioned in #59958 (though I still want to land the REPL changes separately in that PR).I'll be fleshing out this description more soon, but for now I just want to use CI-built Julia to make it easier for friendly testers to try this out and provide feedback/bug-hunt.
Closes: #54561