Skip to content

Conversation

@DanielVandH
Copy link
Contributor

Fixes #450

@codecov
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (47c15ab) to head (d30ff72).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   89.61%   89.84%   +0.23%     
==========================================
  Files          25       25              
  Lines        3571     3643      +72     
==========================================
+ Hits         3200     3273      +73     
+ Misses        371      370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH
Copy link
Contributor Author

I guess LTS has a different way of handling these layouts? Am I testing this poorly or can I just add an additional specific cholcopy test and skip the layout tests on LTS?

@dlfivefifty dlfivefifty merged commit d8e10c7 into JuliaLinearAlgebra:master Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cholesky of a view of a BandedMatrix forgets the structure

2 participants