Moved to Julia 0.7 #31
Conversation
|
Thanks for doing this! |
|
sorry for my absence, I have not switched to 0.7 yet i haven't looked in detail but isn't this basically doing the same as #29 ? |
|
#29 is staling since january, so better go with this |
|
Yep, I tried #29 first, but it turned to be easier for me to just do it myself from scratch. I've removed Manifest.toml now. @Evizero What's your plan for 0.7? If you plan to switch in, say, 1 month, we can put off this PR until then (in Julia 0.7 we can specify branches in dependencies anyway). Otherwise or if you want to keep compatibility with previous versions for a long time I can put Compat back and update the PR. |
|
I really don't know. I have a deadline in 11 days that I am focused on right now. Might be pretty soon after that |
|
Cool! So let's just wait until then. |
Project.toml
Outdated
| name = "LearnBase" | ||
| uuid = "7f8f8fb0-2700-5f03-b4bd-41f8cfc144b6" | ||
| repo = "https://github.com/JuliaML/LearnBase.jl.git" | ||
| version = "0.2.0" |
There was a problem hiding this comment.
I'm not sure about this ... maybe remove the version line so that it doesn't conflict with new tags?
There was a problem hiding this comment.
I thought Pkg3 uses this line instead of tags to figure out dependency versions, doesn't it?
In a couple of my 0.7-ready packages I just set the same number in attobot, but maybe there's a smarter way.
appveyor.yml
Outdated
| - JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x86/0.6/julia-0.6-latest-win32.exe" | ||
| - JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x64/0.6/julia-0.6-latest-win64.exe" | ||
| - JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x86/0.7/julia-0.7.0-beta-win32.exe" | ||
| - JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x64/0.7/julia-0.7.0-beta-win64.exe" |
There was a problem hiding this comment.
This doesn't block the PR from being merged, but this can be
environment:
matrix:
- julia_version: 0.7
- julia_version: latest
joshday
left a comment
joshday
left a comment
There was a problem hiding this comment.
Just getting around to taking a good luck at this PR. My understanding is that we shouldn't add Project.toml files yet as they will be automatically added by a yet-to-be-made upgrade tool. If you just remove the Project.toml file I'm ready to merge.
|
Yeah, I've just seen a discussion about AppVeyor is red again, but it looks like an error in the service itself or environment settings. If tests pass locally on Windows, I'd just leave it as is for now. |
|
I just pushed a commit that I think should fix appveyor. We'll see in a moment! |
|
That fixed appveyor. Now I just bumped the StatsBase version to the latest 0.7-only release. I'll merge once everything is green. Thanks for tackling this @dfdx! |
|
thanks! |
4 participants
Is it already time to move to Julia 0.7? This PR drops support for all previous versions and fixes errors & deprecations for Julia 0.7-beta.
Besides deprecations, the only change is addition of
==method forIntervalSetandDiscreteSetwhich otherwise require iteration on Julia 0.7 (I guess on 0.6 they were compared by reference).