Add support to calculate analytical derivative of ifelse function #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/differentiate.jl
Outdated
Collaborator
There was a problem hiding this comment.
Please use an in-line expression instead of parse, e.g.,
:(ifelse($(args[1]), $(differentiate(args[2],wrt)),$(differentiate(args[3],wrt))))
Author
|
I switched to using an expression as suggested, much more beautiful now, thanks. |
Collaborator
|
Looks good to me. |
Collaborator
|
Would you mind a quick squashing rebase? Happy to merge this right after. |
…suming it was used to define piecewise functions). Use inline expression instead of parse for differentiation of ifelse funtion
Author
|
Done, I "squashed" everything into a single commit. |
johnmyleswhite
added a commit
that referenced
this pull request
Dec 16, 2014
Add support to calculate analytical derivative of ifelse function
Collaborator
|
Great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a few lines to differentiate.jl in order to support analytical differentiation of the ifelse function which can be used to define piecewise functions. It simply returns a new ifelse function with the derivative of the second and third arguments and it also works with nested ifelse.
It does not check whether the piecewise function is differentiable and continuous (it is up to the user to make sure that is the case).