update deprecated Array constructor for Julia v0.6 (drops v0.3 support) #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'd just drop 0.3 and 0.4. |
Collaborator
Author
|
As suggested, this PR now drops Julia v0.3 support since the depwarn fix doesn't work on v0.3. I've kept support for v0.4, since tests are still passing on v0.4. |
jrevels
changed the title
Collaborator
Author
|
I plan on merging this tomorrow (giving @johnmyleswhite some time to chime in if he's against dropping v0.3 support). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculus technically supports Julia v0.3 in its REQUIRE file, and I'm not sure this fix will work on v0.3. Could you use
Vector{T}(n)andMatrix{T}(n, m)back then? I guess Travis should tell us...